Add optional tox configuration #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnoopJ
commented
Jun 9, 2023
dgw
reviewed
Jun 10, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
This being contrib/, I won't nitpick too much. I like to trust that contrib/ stuff already works for the person submitting it, or they wouldn't submit it.
I do still have housekeeping stuff to say, though: What are these commit messages? Where is your module: prefix? 😛
dgw
approved these changes
Jul 13, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Just one nit worth mentioning, but I think this is ready once squashed to a sane history with the correct "module" prefixes.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
toxconfiguration for use with Sopel. It's dgw's fault!Checklist
toxfile.pydoes include some plugin code licensed under MIT, not sure if that is a problem incontrib/make qa(runsmake qualityandmake test)