bot: don't add duplicate timestamp into error log line #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Trigger causes an error in a plugin, we already know when the error happened because the logger call is timestamped. The error as reported to IRC also is timestamped, and `datetime.now()` is not useful data. (It is, however, confusing data. Considered replacing it with `trigger.time` but decided against that, since `server-time` means those could be in the past/future, making the timestamp embedded in the log message even *more* confusing instead of less.)
dgw
force-pushed
the
trigger-error-no-dup-timestamp
branch
from
23e5faf to
ff64350
Compare
Exirel
approved these changes
Jun 15, 2023
SnoopJ
approved these changes
Jun 15, 2023
Contributor
SnoopJ
left a comment
SnoopJ
left a comment
There was a problem hiding this comment.
Agreed, emitting this data on IRC is mostly noise, and we're not losing anything since it's in the logs anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Trigger causes an error in a plugin, we already know when the error happened because the logger call is timestamped. The error as reported to IRC also is timestamped, and
datetime.now()is not useful data.(It is, however, confusing data. Considered replacing it with
trigger.timebut decided against that, sinceserver-timemeans those could be in the past/future, making the timestamp embedded in the log message even more confusing instead of less.)Checklist
make qa(runsmake qualityandmake test)