Skip to content

lifecycle: issue deprecation notices in pre-releases #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgw merged 2 commits into from
Oct 16, 2023
Merged

lifecycle: issue deprecation notices in pre-releases #2522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c6f63c
lifecycle: simplify deprecation warning version check
SnoopJ Oct 14, 2023
5862023
lifecycle: use release version only for deprecation warning
SnoopJ Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sopel/lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ def decorator(func):

@functools.wraps(func)
def deprecated_func(*args, **kwargs):
if not (warning_in and
parse_version(warning_in) >= parse_version(__version__)):
warn_ver = warning_in and parse_version(warning_in).release
this_ver = parse_version(__version__).release

if not (warn_ver and warn_ver >= this_ver):
original_frame = inspect.stack()[-stack_frame]
mod = inspect.getmodule(original_frame[0])
module_name = None
Expand Down