-
-
Notifications
You must be signed in to change notification settings - Fork 409
ip: remove plugin extracted to external package #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derps all sorted out from my end, including the correct title format based on the last half-dozen times we've done this. Just need a squash & commit-message edit.
54e08a1 to
0752ff8
Compare
|
We've published sopel-iplookup 1.0.0. I had a soft-block on this being merged before publication, despite @SnoopJ's "YOLO" above, but the plugin's up now so |
Exirel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay let's go!
|
I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go. I'd also like the Coveralls check statuses to report properly… They're getting stuck on Pending a lot lately and it always seems to be on commits that don't touch any code. 🤔 |
bd1e6f1 to
e4c5166
Compare
Rebased, should be the case now.
Yea, dunno what's going on with them 🤷 |
Description
This PR removes the built-in
ipplugin in favor of the newly packageizedsopel-iplookupplugin, as part of #1291. Note that since #2504 hasn't landed yet, I'm still using the oldermodulesterminology here, but if that PR lands first, this one should be reworked to use the new terminology.This should not be merged untilEdit: YOLO merge whenever I guesssopel-iplookuphas been uploaded to PyPI.I have marked this as a breaking change because, per discussion on IRC, we decided that it makes sense for the new package to name the plugin
iplookuprather than the more genericip. If users mentionipin their bot configuration (i.e. to exclude it), they will need to change the name to account for that.Checklist
make qa(runsmake lintandmake test)