plugin: require_bot_privilege() implies require_chanmsg()
#2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
Tweak
Breaking Change
SnoopJ
approved these changes
Dec 6, 2023
Contributor
SnoopJ
left a comment
SnoopJ
left a comment
There was a problem hiding this comment.
Had some nits, but I don't fundamentally object to this change since the decorator is fundamentally about channels, so I say let's do it.
dgw
force-pushed
the
implied-chanmsg-bot_priv
branch
from
3872427 to
ff98f78
Compare
If the bot needs a channel privilege for a given callable, it probably wants to do something related to channel operations, and triggering such a callable in response to a private message makes no sense.
Member
Author
|
Each assertion now has the message, and I skipped the logger call given @Exirel's valid point about "span" (🇫🇷? 😁) in the logs. Ready to be merged over the weekend unless one of y'all swings by with a last-minute objection. 🙂 |
Exirel
approved these changes
Dec 9, 2023
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
valid point about "span" (🇫🇷? 😁)
Nah, just a stupid typo from a 🧠 💨
Ready to be merged over the weekend unless one of y'all swings by with a last-minute objection. 🙂
GO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the bot needs a channel privilege for a given callable, it probably wants to do something related to channel operations, and triggering such a callable in response to a private message makes no sense.
Sorry about trying to add something into 8.0.0 this late… I've been writing the 8.0 migration guide tonight, and when I ran across #2405 I realized that #2399 should have contemplated doing this too. If we're gonna "breaking change" privilege-decorator stuff, we should do it all in one major version.
If others agree that this is a good idea we can just merge the patch that's already ready to go and get on with finishing the release. (That's why I didn't open an issue first, to shorten the discuss -> implement -> review cycle.)
Checklist
make qa(runsmake lintandmake test)