Miscellaneous type-checking updates #2614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
types-pkg-resourceswas yanked, which I discovered when submitting #2613.pkg_resourcesitself is typed in setuptools>=71.1, negating the need to install type stubs.When testing that fix, I updated
mypyand friends (pip install -U -r dev-requirements.txt) and found a few more new type-check errors caught by the newer tools:SopelIdentifierMemory.update()'s signature isn't compatible with its supertype (fixed by addingtyping_extensions.overridedecorator; can't go stdlib-only until py3.12…)tools.OutputRedirectcalls methods onsys.__stdout__andsys.__stderr__, which are allowed to beNoneand therefore have to be guarded withifs (I'm glad this class is deprecated)Checklist
make qa(runsmake lintandmake test)Notes
All of this needs backporting to the
8.0.xmaintenance branch, which is why this has the 8.0.1 milestone.