irc: versionadded notes + Optional annotation migration
#2642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might as well migrate as we touch things. I just updated some docstring stuff in `irc/__init__.py`, and as long as I'm in the file let's get rid of the `typing.Optional` import, too.
dgw
added
Documentation
Housekeeping
Exirel
approved these changes
Nov 11, 2024
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
That's a lot of work to track everything down to its version of origin. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes care of #2602 as far as what directly prompted me to slot it into the 8.0.1 milestone, with new
versionaddedannotations in the docstrings of stuff that's new-ish (added in 7.x or later). I figure after this PR, that issue can become a general checklist of which submodules have been looked at again since 8.0.0 and live un-milestoned for a while.Maybe we should also have a tracking issue for the second half of this PR, which starts the process of something we talked about in other patches: Replacing use of
typing.Optionalwith| None. Right now I think "just migrate the files you touch" is better than a "touch ALL the things!" PR, but we still should keep track of what's been done.Checklist
make qa(runsmake lintandmake test)make lintonly locally, as no runtime code is touched