bot: round rate limit time_left value up, eliminate microseconds
#2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes rate limit feedback from the bot more readable. We could go full-on custom format, but honestly the built-in string representation of a timedelta is perfectly serviceable if you get rid of the microseconds portion. (How you get there is pretty ugly, but it's not AS bad as a whole new helper function in `tools.time`.)
SnoopJ
approved these changes
Feb 1, 2025
Contributor
SnoopJ
left a comment
SnoopJ
left a comment
There was a problem hiding this comment.
You know, I don't mind this solution as much when you format it across multiple lines like that. Nice tidy fix.
Exirel
approved these changes
Feb 1, 2025
dgw
added a commit
that referenced
this pull request
Feb 1, 2025
bot: round rate limit `time_left` value up, eliminate microseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes rate limit feedback from the bot more readable. Fixes #2651.
Checklist
make qa(runsmake lintandmake test)