Fix MRI Ruby vs. JRuby XML child namespace output differences#3456
Fix MRI Ruby vs. JRuby XML child namespace output differences#3456flavorjones merged 18 commits intosparklemotion:mainfrom
Conversation
|
@flavorjones please approve CI, thanks! |
|
I'm not opposed to this approach. I'm wondering if the namespace stack should be managed in the |
|
@flavorjones I think you're right, I'll look more into getAttrsAndNamespaces tomorrow |
|
Thank you so much for diving in and drafting this pull request! I sincerely wish there were more folks like you, who are willing to contribute to the JRuby implementation. ❤️ |
|
@flavorjones code is ready for a review. What is the best way to test this? Are there instructions on how to build JRuby locally? |
|
@johnnyshields Existing "how to contribute" docs are at https://github.com/sparklemotion/nokogiri/blob/main/CONTRIBUTING.md but the TLDR is |
|
@flavorjones This is ready for final review. While testing I found two separate issue unrelated to this PR: |
flavorjones
left a comment
There was a problem hiding this comment.
Thank you for the thorough test coverage! ❤️
|
@flavorjones all comments are addressed, please check. |
flavorjones
left a comment
There was a problem hiding this comment.
Looks good, will merge if the test suite passes.
|
Will get this into a bugfix release soon. But first I'd like to see if I can easily fix the other bugs we're finding and get them in, too. |
|
@flavorjones awesome, I really appreciate it! |
|
@johnnyshields I really appreciate you digging in and fixing this! |
|
Side note: I'm integration testing Nokogiri Should I be testing ruby-saml with JRuby as well, do you think? You're obviously finding edge cases that nobody else has in 15+ years so it might be worthwhile ... |
|
@flavorjones yes, please test JRuby and TruffleRuby for RubySaml if possible 🙏 |
|
See #3465 for CI coverage |
|
Great work here! |
…rt v1.18x) (#3476) **What problem is this PR intended to solve?** Fix MRI Ruby vs. JRuby XML child namespace output differences Fixes #3455 Backport of #3456 cc @johnnyshields
Fixes #3455