Skip to content

Conversation

@Drewdan
Copy link
Contributor

@Drewdan Drewdan commented Apr 20, 2020

When developing using this package, I wanted to add a new notification type. So I created a new class an extened the \Illuminate\Notifications\Notification class however I received an error stating the new class I made had to extend the Illuminate\Notifications\Notification class, which my class was doing.

A workaround is extending the Spatie\FailedJobMonitor\Notification - however, the error message does not suggest this to be the correct source of action.

This pull request resolves the issue by importing the Illuminate\Notifications\Notification and uses it in the isValidNotificationClass method.

@freekmurze freekmurze merged commit 48999e0 into spatie:master Apr 20, 2020
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants