allows extension of illuminate notification class #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing using this package, I wanted to add a new notification type. So I created a new class an extened the
\Illuminate\Notifications\Notificationclass however I received an error stating the new class I made had to extend theIlluminate\Notifications\Notificationclass, which my class was doing.A workaround is extending the
Spatie\FailedJobMonitor\Notification- however, the error message does not suggest this to be the correct source of action.This pull request resolves the issue by importing the
Illuminate\Notifications\Notificationand uses it in theisValidNotificationClassmethod.