Skip to content

Conversation

@bilogic
Copy link

@bilogic bilogic commented Jun 9, 2025

  1. Make it easier to trace bounced/failed emails back to this package using [email protected]
  2. In fact, I would even disable slack by default, because
    • the error Driver [slack] not supported. is very vague when FAILED_JOB_SLACK_WEBHOOK_URL is not provided, no indication it is caused by this package
    • I suspect among those who install this, lesser of them have a slack webhook URL

@freekmurze
Copy link
Member

Thanks, but I'm going to leave the email like it is for now.

Feel free to submit a PR to fix the default behavior of the slack messages.

@freekmurze freekmurze closed this Jun 10, 2025
@bilogic
Copy link
Author

bilogic commented Jun 10, 2025

ok thanks, submitted the other PR

I have to say, both config defaults result in very vague errors, its odd to me to fix the other but not this.

For this email one, I only know when I see a bunch bounced emails in my inbox (after failed jobs which don't occur all the time).

But since [email protected] is so generic, I assumed it was from Laravel, until I realized that not all projects have this error.

The mystery is only solved when I thought much harder and decided to search my code for [email protected].

Config defaults in general should not trigger any unhappy paths, hope you will reconsider thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants