Improve Google Cloud Storage URL generation logic using bucket name

[neoformalex]

Google Cloud PHP package depricates DEFAULT_API_ENDPOINT and uses bucket name from the configuration.

[neoformalex]

Poke @freekmurze 🙂

[freekmurze]

Thanks!

[jon-sm]

Hello!

This release is changing URL generation under the same configuration. We use a cloudflare DNS subdomain proxy pointing to the GCS bucket URL.

GOOGLE_CLOUD_STORAGE_API_URI=https://files.domain.com -> pointed to https://storage.googleapis.com/bucket-name/

In this scenario now all URLs are 404s since they are pointing to https://storage.googleapis.com/bucket-name/bucket-name/foo.

I am lacking context for the purpose of the change but I can't seem to replicate previous behaviour without changing our DNS record. Do you have any insight?

Thank you!

[BertvanHoekelen]

This shouldn't have been in a minor release as the default endpoint got changed and the "https://storage.googleapis.com/" from all url's went missing without setting up the GOOGLE_CLOUD_STORAGE_API_URI env variable.

For other people running into this issue:
Just add GOOGLE_CLOUD_STORAGE_API_URI=https://storage.googleapis.com/ to your environment variables.

[FernandoABC]

This causes conflict when there is no storageApiUri configured, in this case we used the default_api_endpoint, this $storageApiUri = rtrim(Arr::get($this->config, 'storageApiUri'), '/'); should be optional if there is some storageApiUri configured if not you should use the default $storageApiUri = rtrim(Rest::DEFAULT_API_ENDPOINT, '/').'/'.ltrim(Arr::get($this->config, 'bucket'), '/'); in order to no break legacy implementations.

[freekmurze]

I've reverted this PR in the latest version.