Change type of exception handled in rejected promise #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in Guzzle's [upgrade document](https://github.com/guzzle/guzzle/blob/master/UPGRADING.md), in Guzzle 7 `GuzzleHttp\Exception\ConnectException` now extends from `GuzzleHttp\Exception\TransferException` instead of `GuzzleHttp\Exception\RequestException`, which now causes a fatal error in the rejected callback because ConnectException is no longer an instance of RequestException. This change allows for ConnectException to be handled when using Guzzle 7 while remaining B/C with Guzzle 6.
Contributor
|
Can this be merged? currently, this package is only working if I include the changes to this PR |
Contributor
|
Thanks! |
Contributor
|
Release in v4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in Guzzle's upgrade document, in Guzzle 7
GuzzleHttp\Exception\ConnectExceptionnow extends fromGuzzleHttp\Exception\TransferExceptioninstead ofGuzzleHttp\Exception\RequestException, which now causes a fatal error in the rejected callback because ConnectException is no longer an instance of RequestException. This change allows for ConnectException to be handled when using Guzzle 7 while remaining B/C with Guzzle 6.