fix: nil map assignment panics on zero-value Viper struct#2124
Open
humanborch wants to merge 1 commit intospf13:masterfrom
Open
fix: nil map assignment panics on zero-value Viper struct#2124humanborch wants to merge 1 commit intospf13:masterfrom
humanborch wants to merge 1 commit intospf13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Lazily initializes internally mutated maps and key delimiters inside
viper.Setandviper.SetDefaultmethods, enabling safe, immediate usability of an uninitialized zero-value&viper.Viper{}struct without map assignment panics.What problem does it solve?:
v := &viper.Viper{}) immediately crashes the host application deep insideutil.go.v.keyDeliminitialization prevents unintended character-by-character map splitting on empty delimiter bindings.Special notes for a reviewer:
Added test-cases (
TestZeroValueViperSetDefault,TestZeroValueViperSet) into the test suite that specifically execute map-binding assignments on the zero-value struct pattern to protect against regression.