Wrong parameter in the FakeBucketFactory #28

New issue

Copy link

New issue

Copy link

Open

Open

Wrong parameter in the FakeBucketFactory#28

Copy link

Assignees

Labels

bugSomething isn't workingSomething isn't working

Description

roxblnfk

opened on Aug 15, 2022

Issue body actions

testing/src/Storage/FakeBucketFactory.php

Lines 23 to 35 in 4f178ab

	public function createFromAdapter(
	FilesystemAdapter $adapter,
	string $name = null,
	UriResolverInterface $resolver = null
	): BucketInterface {
	return new FakeBucket(
	new Filesystem(
	new LocalFilesystemAdapter($this->path . '/' . $name)
	),
	$name,
	$resolver
	);
	}

The createFromAdapter() method has the $adapter parameter that isn't used but it is required.
I think there is some bug.

Activity

1. roxblnfk

   assigned

   butschster

   on Aug 15, 2022
2. roxblnfk

   added this to Spiral frameworkon Aug 15, 2022
3. roxblnfk

   moved this to Todo in Spiral frameworkon Aug 15, 2022
4. butschster

   added

   bugSomething isn't workingSomething isn't working

   on Sep 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

• 
  butschster

Labels

bugSomething isn't workingSomething isn't working

Type

No type

Projects

• Spiral framework

  Status

  Todo

  Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

• Open in GitHub Copilot app