Merged
Conversation
I ran "bundle exec rake gem:gemspec" and this is what changed, except the date (did not change the date as I think that should reflect when releases are made). Related to sporkmonger#460 and sporkmonger#463 that both updated the generated gemspec directly. Includes the change from sporkmonger#425.
dentarg
commented
Jul 25, 2022
| s.email = "bob@sporkmonger.com".freeze | ||
| s.extra_rdoc_files = ["README.md".freeze] | ||
| s.files = ["CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "addressable.gemspec".freeze, "benchmark".freeze, "coverage".freeze, "data".freeze, "data/unicode.data".freeze, "documentation".freeze, "gemfiles".freeze, "lib".freeze, "lib/addressable".freeze, "lib/addressable.rb".freeze, "lib/addressable/idna".freeze, "lib/addressable/idna.rb".freeze, "lib/addressable/idna/native.rb".freeze, "lib/addressable/idna/pure.rb".freeze, "lib/addressable/template.rb".freeze, "lib/addressable/uri.rb".freeze, "lib/addressable/version.rb".freeze, "spec".freeze, "spec/addressable".freeze, "spec/addressable/idna_spec.rb".freeze, "spec/addressable/net_http_compat_spec.rb".freeze, "spec/addressable/security_spec.rb".freeze, "spec/addressable/template_spec.rb".freeze, "spec/addressable/uri_spec.rb".freeze, "spec/spec_helper.rb".freeze, "specdoc".freeze, "tasks".freeze, "tasks/clobber.rake".freeze, "tasks/gem.rake".freeze, "tasks/git.rake".freeze, "tasks/metrics.rake".freeze, "tasks/profile.rake".freeze, "tasks/rspec.rake".freeze, "tasks/yard.rake".freeze, "tmp".freeze] | ||
| s.files = ["CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "data/unicode.data".freeze, "lib/addressable".freeze, "lib/addressable.rb".freeze, "lib/addressable/idna".freeze, "lib/addressable/idna.rb".freeze, "lib/addressable/idna/native.rb".freeze, "lib/addressable/idna/pure.rb".freeze, "lib/addressable/template.rb".freeze, "lib/addressable/uri.rb".freeze, "lib/addressable/version.rb".freeze, "spec/addressable".freeze, "spec/addressable/idna_spec.rb".freeze, "spec/addressable/net_http_compat_spec.rb".freeze, "spec/addressable/security_spec.rb".freeze, "spec/addressable/template_spec.rb".freeze, "spec/addressable/uri_spec.rb".freeze, "spec/spec_helper.rb".freeze, "tasks/clobber.rake".freeze, "tasks/gem.rake".freeze, "tasks/git.rake".freeze, "tasks/metrics.rake".freeze, "tasks/profile.rake".freeze, "tasks/rspec.rake".freeze, "tasks/yard.rake".freeze] |
Collaborator
Author
There was a problem hiding this comment.
I think this change removed the following: ["addressable.gemspec", "benchmark", "coverage", "data", "documentation", "gemfiles", "lib", "spec", "specdoc", "tasks", "tmp"]
Not sure how they got there in the first place?
Collaborator
Author
There was a problem hiding this comment.
Maybe use of newer RubyGems makes a difference
Contributor
|
@dentarg Once the gemspec updates are complete and any other changes are merged, would you be able to release an updated gem? Thanks. |
Collaborator
Author
|
Missed this comment but I replied at #465 (comment) |
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Mar 4, 2023
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: sporkmonger#466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"]
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Apr 1, 2023
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: sporkmonger#466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"] Exclude `coverage` directory from files list as it is ignored by git.
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Apr 1, 2023
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: sporkmonger#466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"] Exclude `coverage` directory from files list as it is ignored by git.
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Apr 1, 2023
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: sporkmonger#466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"] Exclude `coverage` directory from files list as it is ignored by git.
dentarg
added a commit
that referenced
this pull request
Apr 1, 2023
Ran `bundle exec rake gem:gemspec` on Ruby 3.2.1 to update the gemspec. Not sure why list of files changed, but it has happened before: #466 (comment) List extended this time with ["addressable.gemspec", "benchmark", "data", "gemfiles", "lib", "spec", "tasks"] Exclude `coverage` directory from files list as it is ignored by git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran "bundle exec rake gem:gemspec" and this is what changed, except
the date (did not change the date as I think that should reflect when
releases are made).
Related to #460 and #463 that both updated the generated gemspec
directly. Includes the change from #425.