Added support for supplying a custom Dockerfile location on build

[npiguet]

I have a use case that requires me to have the Dockerfile in a subfolder of my maven project, but I still want to be able to ADD files and resources that are located in my projects /target folder to my image.

Therefore, I need the build mojo to support the -f PATH argument of docker build.

This changeset adds this support (with matching integration tests)

[npiguet]

I have no idea why the travis CI build failed... It looks unrelated to this branch. It looks like it became stuck while pulling docker images. Not sure where that could come from.

[npiguet]

Does anyone know how I can relaunch a Travis CI build? The last one looks like it failed in some infrastructure code, not in the changes in the pull request. I don't like seeing red when it should be green.

And I would really need this to be merged.

[mattnworb]

I re-triggered a build run. I believe only repo owners can do that in TravisCI, which can be a headache.

[npiguet]

Looks like it's passing. Any chance to have it merged?

[Shingaz]

We are waiting for this feature too.

[jhaeyaert]

+1 for this feature.
Is it planned to be merged ?

Thx

[ghost]

+1
I'm remaining on the legacy docker-maven-plugin until this feature is merged in. We have one parent POM project which a number of child projects inherit from. They all use the same Dockerfile from the parent. The only way I've been able to get this plugin to perform the same behavior is to copy-pasta that parent Dockerfile into every child module due to the child build directory not being accessible to the build context. Makes for a painful process to update that Dockerfile 15+ times.

[vijay-js]

Any idea on when this is going to be merged?

[blaketsk]

+1

[cataling]

+1

[mgvazquez]

+1

[vivimice]

+1

[dnsbtchr]

+1

[yueli9]

+1, this will be very helpful!

[davidgamez]

+1, any idea on when this can be merged, I found it very helpful.

[jccode]

+1

[Ellene]

+1

[phanvuliem]

+1

[hjchanna]

+1

[masterBrog]

+1 any news on this? seems to have gone quiet...

[gaurav517]

Merge it please! or if anyone knows a workaround, please share. Thanks. @mattnworb @npiguet

[Satroler]

+1

[dstanoev]

+1

[eyeqinglan]

can resolve by add this plugin operate

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-resources-plugin</artifactId>
        <version>${maven.resources.version}</version>
        <executions>
          <execution>
            <id>copy-docker-resources</id>
            <phase>generate-resources</phase>
            <goals>
              <goal>copy-resources</goal>
            </goals>
            <configuration>
              <outputDirectory>target</outputDirectory>
              <resources>
                <!-- copy docker resources -->
                <resource>
                  <directory>${project.basedir}/src/main/Docker</directory>
                </resource>
              </resources>
            </configuration>
          </execution>
        </executions>
      </plugin>

[ncc0706]

+1

[habeeb-umo]

Please merge ASAP!

[php-coder]

@npiguet I see that this PR has conflict now and can't be merged (even if authors would like to do so). Are you still interesting in this PR? Could you update it? Thanks!

[juliabenatti]

+1

[jchacana]

+1. I'm staying with legacy plugin waiting for this PR :(

[cristiker]

+1

[acoulson2000]

+1

[Bryann]

+1

[mattnworb]

sorry for the very long delay everyone. I'll try to resolve this now - had to resolve some conflicts.

[mattnworb]

not sure why Travis is not reporting status, but verified this passes all tests locally

[mattnworb]

1.4.10 has been released with this change

[Bryann]

Thanks! :)