This repository was archived by the owner on Apr 5, 2022. It is now read-only.
XD-3251: Add a boot @ConfigurationProperties compatible MOMResolver. #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to latest Boot SNAPSHOT, upgrade Spring Batch.
|
|
||
| @PostConstruct | ||
| public void forceScheduledTaskExecutor() { | ||
| postProcessor.setScheduler(frameworkTaskScheduler); |
There was a problem hiding this comment.
Interesting technique 😄
A couple of thoughts...
- Perhaps we should open a JIRA against SF to fall back to some well-known bean name when there's more than one scheduler in the context?
- We should probably document someplace how users can override this "framework" scheduler if they want multiple threads in the
TPTS
There was a problem hiding this comment.
+1 to Gary's comments, and...
I'm not a fan of the word "framework" here.
Also the thread prefix should be set.
|
Closing as s-c-d is its own project, not going through the soft transition path |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to latest Boot SNAPSHOT (introduce an explicit task scheduler for "framework" tasks, different from the batch and SI schedulers), upgrade Spring Batch.
Add a boot @ConfigurationProperties compatible MOMResolver.
With this PR merged, one could drop a spring-cloud-stream module (such as the one resulting from spring-cloud/spring-cloud-stream#19) and properly see its "module options". Obviously, running the module as-is won't work, will need adaptation to the execution environment (in the form of the SPI @pperalta is working on) with the knowledge that any module option
--foo=xxxmust actually be passed to the s-c-s module asmodule.foo=xxx.