Update tools.adoc About toolDefinition parameter transfer error

[RobinElysia]

Method method = ReflectionUtils.findMethod(DateTimeTools.class, "getCurrentDateTime");
ToolCallback toolCallback = MethodToolCallback.builder()
.toolDefinition(ToolDefinition.builder() // Shouldn't method be passed here?
.description("Get the current date and time in the user's timezone")
.build())
.toolMethod(method)
.toolObject(new DateTimeTools())
.build();

[sunyuhan1998]

Please refer to the following source code. I don't think there is any error in the document itself. Could you please double-check it?

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/support/ToolDefinitions.java

Line 47 in 694bb50

public static DefaultToolDefinition.Builder builder(Method method) {

[RobinElysia]

请参考以下来源代码。我认为文档本身没有任何错误。您可以再检查一下吗？

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/support/ToolDefinitions.java

Line 47 in 694bb50

public static DefaultToolDefinition.Builder builder(Method method) {

Ok, maybe it's my version problem.😂

[RobinElysia]

Please refer to the following source code. I don't think there is any error in the document itself. Could you please double-check it?

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/support/ToolDefinitions.java

Line 47 in 694bb50

public static DefaultToolDefinition.Builder builder(Method method) {

No, no, no, that's not right. The version is fine. Sorry, it seems to be the fault of the document sample.😦

[RobinElysia]

请参考以下来源代码。我认为文档本身没有任何错误。您可以再检查一下吗？

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/support/ToolDefinitions.java

Line 47 in 694bb50

public static DefaultToolDefinition.Builder builder(Method method) {

This should be the interface：
spring-ai-model/src/main/java/org/springframework/ai/tool/definition/ToolDefinition.java

[sunyuhan1998]

I'm a bit confused about what you mean, the sample code in the current sample documentation is as follows:

spring-ai/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/tools.adoc

Lines 318 to 324 in 694bb50

	ToolCallback toolCallback = MethodToolCallback.builder()
	.toolDefinition(ToolDefinitions.builder(method)
	.description("Get the current date and time in the user's timezone")
	.build())
	.toolMethod(method)
	.toolObject(new DateTimeTools())
	.build();

According to the interface definition, the org.springframework.ai.tool.method.MethodToolCallback.Builder#toolDefinition method receives a parameter of type ToolDefinition:

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/method/MethodToolCallback.java

Lines 210 to 213 in 694bb50

	public Builder toolDefinition(ToolDefinition toolDefinition) {
	this.toolDefinition = toolDefinition;
	return this;
	}

and ToolDefinitions.builder(method).build() returns a ToolDefinition:

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/definition/DefaultToolDefinition.java

Line 67 in 694bb50

public ToolDefinition build() {

which I don't seem to see a problem with.

[RobinElysia]

I'm a bit confused about what you mean, the sample code in the current sample documentation is as follows:

spring-ai/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/tools.adoc

Lines 318 to 324 in 694bb50

	ToolCallback toolCallback = MethodToolCallback.builder()
	.toolDefinition(ToolDefinitions.builder(method)
	.description("Get the current date and time in the user's timezone")
	.build())
	.toolMethod(method)
	.toolObject(new DateTimeTools())
	.build();

According to the interface definition, the org.springframework.ai.tool.method.MethodToolCallback.Builder#toolDefinition method receives a parameter of type ToolDefinition:

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/method/MethodToolCallback.java

Lines 210 to 213 in 694bb50

	public Builder toolDefinition(ToolDefinition toolDefinition) {
	this.toolDefinition = toolDefinition;
	return this;
	}

and ToolDefinitions.builder(method).build() returns a ToolDefinition:

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/definition/DefaultToolDefinition.java

Line 67 in 694bb50

public ToolDefinition build() {

which I don't seem to see a problem with.

ok,I think i get it

[ilayaperumalg]

@RobinElysia Thanks for the PR fixing the doc.

[sunyuhan1998]

@RobinElysia Thanks for the PR fixing the doc.

Hi @ilayaperumalg , I think this merge might be a mistake, because the original document was correct — ToolDefinitions does not have a builder() method that accepts no parameters.

spring-ai/spring-ai-model/src/main/java/org/springframework/ai/tool/support/ToolDefinitions.java

Lines 38 to 62 in 23c38df

	public final class ToolDefinitions {
	private ToolDefinitions() {
	// prevents instantiation.
	}
	/**
	* Create a default {@link ToolDefinition} builder from a {@link Method}.
	*/
	public static DefaultToolDefinition.Builder builder(Method method) {
	Assert.notNull(method, "method cannot be null");
	return DefaultToolDefinition.builder()
	.name(ToolUtils.getToolName(method))
	.description(ToolUtils.getToolDescription(method))
	.inputSchema(JsonSchemaGenerator.generateForMethodInput(method));
	}
	/**
	* Create a default {@link ToolDefinition} instance from a {@link Method}.
	*/
	public static ToolDefinition from(Method method) {
	return builder(method).build();
	}
	}

[ilayaperumalg]

@sunyuhan1998 yes, sorry about that. fixing the doc now

[ilayaperumalg]

Reverted the change. @sunyuhan1998 Thanks for pointing it out.