Skip to content

Make in-memory database tests default to using random name #7102

Closed
@philwebb

Description

@philwebb
Member

See #7004 for background.

Activity

added this to the 1.5.0 milestone on Oct 5, 2016
modified the milestones: 1.5.0 RC1, 1.5.0 on Nov 24, 2016
snicoll

snicoll commented on Nov 24, 2016

@snicoll
Member

@philwebb what did you have in mind for this. Do I understand we want to override the property when our test annotations are used? Somewhere in SpringBootTestContextBootstrapper#processPropertySourceProperties maybe?

philwebb

philwebb commented on Nov 29, 2016

@philwebb
MemberAuthor

I didn't really have anything in mind, I just added the bug when #7004 was raised so we didn't forget about it. Perhaps we can add something to AutoConfigureTestDatabase?

snicoll

snicoll commented on Nov 30, 2016

@snicoll
Member

Perhaps we can add something to AutoConfigureTestDatabase?

It's already done (#7473) and it isn't the same thing IMO. If we want this to be transparent, it should apply regardless of the test slice. Arguably an integration test should have a fresh database per cached context as well. IMO the best place is the one I've referenced above but I am happy to be proven wrong.

snicoll

snicoll commented on Nov 30, 2016

@snicoll
Member

Let's stick with #7473 and let users enable that setting for integration tests as we need a way for them to opt-in.

added
status: declinedA suggestion or change that we don't feel we should currently apply
and removed
for: team-attentionAn issue we'd like other members of the team to review
on Nov 30, 2016
removed this from the 1.5.0 RC1 milestone on Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: declinedA suggestion or change that we don't feel we should currently apply

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @snicoll@philwebb

        Issue actions

          Make in-memory database tests default to using random name · Issue #7102 · spring-projects/spring-boot