-
Notifications
You must be signed in to change notification settings - Fork 41.3k
Add property ROLLING_FILE_LOG_PATTERN for File Appender #18151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ct/spring-boot/src/main/resources/org/springframework/boot/logging/logback/file-appender.xml
Outdated
Show resolved
Hide resolved
Should this also be added in the documentation somewhere ? (https://docs.spring.io/spring-boot/docs/current/reference/html/howto-logging.html) |
3efb11b
to
2b9006f
Compare
PR has been updated. Thanks @jorgheymans and @wilkinsona |
2b9006f
to
35f3074
Compare
I am wondering if the property shouldn't be Rather than |
@snicoll should I apply the changes suggested? |
If you have time shortly, feel free to do it. I intended to polish your PR sometime Monday. Either is fine, thanks for asking! |
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file`. See spring-projectsgh-18140
35f3074
to
66e185b
Compare
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file-name`. See gh-18151
Thanks @eddumelendez |
This new property allows to customize `fileNamePattern` if it is set. Otherwise, a default pattern remains. Also, new property is supported `logging.pattern.rolling-file-name`. See spring-projectsgh-18151
This new property allows to customize
fileNamePattern
if it is set.Otherwise, a default pattern remains. Also, new property is supported
logging.pattern.rolling-file
.See gh-18140