Skip to content

Add property ROLLING_FILE_LOG_PATTERN for File Appender #18151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Sep 6, 2019

This new property allows to customize fileNamePattern if it is set.
Otherwise, a default pattern remains. Also, new property is supported
logging.pattern.rolling-file.

See gh-18140

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2019
@jorgheymans
Copy link

Should this also be added in the documentation somewhere ? (https://docs.spring.io/spring-boot/docs/current/reference/html/howto-logging.html)

@eddumelendez
Copy link
Contributor Author

PR has been updated. Thanks @jorgheymans and @wilkinsona

@eddumelendez eddumelendez changed the title Add property LOG_FILENAME_PATTERN for File Appender Add property ROLLING_FILE_LOG_PATTERN for File Appender Sep 8, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 9, 2019
@philwebb philwebb added this to the 2.2.x milestone Sep 9, 2019
@snicoll snicoll self-assigned this Sep 11, 2019
@snicoll
Copy link
Member

snicoll commented Sep 11, 2019

I am wondering if the property shouldn't be logging.pattern.rolling-file-name as we have a logging.pattern.file that provides a pattern for the log content, not the name of the file.

Rather than ROLLING_FILE_LOG_PATTERN it could be ROLLING_FILE_NAME_PATTERN.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Sep 11, 2019
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge and removed for: team-attention An issue we'd like other members of the team to review labels Sep 13, 2019
@eddumelendez
Copy link
Contributor Author

@snicoll should I apply the changes suggested?

@snicoll
Copy link
Member

snicoll commented Sep 14, 2019

If you have time shortly, feel free to do it. I intended to polish your PR sometime Monday. Either is fine, thanks for asking!

Verified

This commit was signed with the committer’s verified signature.
theofidry Théo FIDRY
This new property allows to customize `fileNamePattern` if it is set.
Otherwise, a default pattern remains. Also, new property is supported
`logging.pattern.rolling-file`.

See spring-projectsgh-18140
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.RC1 Sep 16, 2019
snicoll pushed a commit that referenced this pull request Sep 16, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This new property allows to customize `fileNamePattern` if it is set.
Otherwise, a default pattern remains. Also, new property is supported
`logging.pattern.rolling-file-name`.

See gh-18151
@snicoll snicoll closed this in f06c250 Sep 16, 2019
@snicoll
Copy link
Member

snicoll commented Sep 16, 2019

Thanks @eddumelendez

pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Sep 16, 2019
This new property allows to customize `fileNamePattern` if it is set.
Otherwise, a default pattern remains. Also, new property is supported
`logging.pattern.rolling-file-name`.

See spring-projectsgh-18151
pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants