Skip to content

Upgrade to Testcontainers 1.12.2 #18446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to Testcontainers 1.12.2 #18446

wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR upgrades Testcontainers to version 1.12.2. Am I right that only the pom.xml under spring-boot-dependencies is covered by bomr and hence the (half-)automatic upgrade process? If not, please ignore this PR. ;-)

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2019
@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 30, 2019
@philwebb philwebb added this to the 2.2.x milestone Sep 30, 2019
@snicoll
Copy link
Member

snicoll commented Oct 1, 2019

@dreis2211 you are right. bomr uses the content of spring-boot-dependencies but it could very well as much looks a different pom if instructed to do so. I thought one could override but it's driven by the yaml file now. They were interesting upgrades in there so I'll look at that a bit more and follow-up accordingly.

Thanks for the nudge!

@snicoll snicoll self-assigned this Oct 1, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0, 2.2.0.RC1 Oct 1, 2019
@snicoll snicoll mentioned this pull request Oct 1, 2019
Closed
snicoll pushed a commit that referenced this pull request Oct 1, 2019
@dreis2211 @snicoll
Upgrade to Testcontainers 1.12.2
3ae3439 
See gh-18446
@snicoll snicoll closed this in a3f9845 Oct 1, 2019
@dreis2211
Copy link
Contributor Author

Thanks @snicoll . That's what I thought as well. If you don't have time, I can take a look too. Just let me know.

@snicoll
Copy link
Member

snicoll commented Oct 1, 2019

I kind of already did and need to dig into the numbers, see #18448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.2.0.RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@dreis2211 @snicoll @philwebb @spring-projects-issues