Skip to content

Trim BindlableMongoExpression input expression #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gbaso
Copy link
Contributor

@gbaso gbaso commented Oct 28, 2024

Closes #4821

gbaso added 2 commits October 25, 2024 23:39

Verified

This commit was signed with the committer’s verified signature.
gbaso Giacomo Baso

Verified

This commit was signed with the committer’s verified signature.
gbaso Giacomo Baso
@gbaso
Copy link
Contributor Author

gbaso commented Jan 9, 2025

@christophstrobl any blockers for this PR?

@christophstrobl
Copy link
Member

@gbaso no, sorry. Will be in for the next service release.

christophstrobl pushed a commit that referenced this pull request Jan 16, 2025

Partially verified

This commit is signed with the committer’s verified signature.
christophstrobl’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Trim the given source so that wrapping checks still work for text blocks.
Fix a typo in Javadoc.

Resolves: #4821
Original Pull Request: #4822
christophstrobl added a commit that referenced this pull request Jan 16, 2025

Verified

This commit was signed with the committer’s verified signature.
christophstrobl Christoph Strobl
Original Pull Request: #4822
christophstrobl pushed a commit that referenced this pull request Jan 16, 2025

Partially verified

This commit is signed with the committer’s verified signature.
christophstrobl’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Trim the given source so that wrapping checks still work for text blocks.
Fix a typo in Javadoc.

Resolves: #4821
Original Pull Request: #4822
christophstrobl added a commit that referenced this pull request Jan 16, 2025

Verified

This commit was signed with the committer’s verified signature.
christophstrobl Christoph Strobl
Original Pull Request: #4822
@christophstrobl
Copy link
Member

Thank you for your contribution @gbaso. Merged to main development line and back ported to 4.4.x.

christophstrobl pushed a commit that referenced this pull request Jan 23, 2025

Partially verified

This commit is signed with the committer’s verified signature.
christophstrobl’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Trim the given source so that wrapping checks still work for text blocks.
Fix a typo in Javadoc.

Resolves: #4821
Original Pull Request: #4822
christophstrobl added a commit that referenced this pull request Jan 23, 2025

Verified

This commit was signed with the committer’s verified signature.
christophstrobl Christoph Strobl
Original Pull Request: #4822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim BindableMongoExpression input to better support text blocks
3 participants