gh-407 - Add ReactiveSortingRepository support #408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable. Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes.
Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples.
mp911de
pushed a commit
that referenced
this pull request
Jul 23, 2020
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable. Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes. Clarify documentation on reactive repository base interfaces Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples. Original pull request: #408.
mp911de
added a commit
that referenced
this pull request
Jul 23, 2020
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository. Original pull request: #408.
mp911de
pushed a commit
that referenced
this pull request
Jul 23, 2020
Implements ReactiveSortingRepository on SimpleR2dbcRepository. Also changed R2dbcRepository to extend ReactiveSortingRepository and updated comments where it felt reasonable. Added a single unit test for the new method, and changed the base interface of LegoSetRepository in AbstractR2dbcRepositoryIntegrationTests for integration testing purposes. Clarify documentation on reactive repository base interfaces Adds some language calling out ReactiveSortingRepository and fixes consistency between related examples. Original pull request: #408.
mp911de
added a commit
that referenced
this pull request
Jul 23, 2020
Guard find(Sort) against null values. Add author to documentation. Use ReactiveDataAccessStrategy in R2dbcEntityTemplate created in SimpleR2dbcRepository. Original pull request: #408.
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ReactiveSortingRepositoryonSimpleR2dbcRepository. Also changedR2dbcRepositoryto extendReactiveSortingRepositoryand updated comments where it felt reasonable.Added a single unit test for the new method, and changed the base interface of
LegoSetRepositoryinAbstractR2dbcRepositoryIntegrationTestsfor integration testing purposes.P.S., Should
SimpleR2dbcRepositoryimplement theR2dbcRepositoryinterface? I don't think it would make any functional difference since the store-specific interface doesn't add any methods, but I was looking at the Reactive Mongo code as a reference while working on this and I noticed that as a difference.