Migrate Grails BeanBuilder into Spring Core [SPR-7123]

[spring-projects-issues]

Jeff Brown opened SPR-7123 and commented

The Spring Bean Builder has been extracted from Grails and is being prepared for inclusion in Spring. Much of the development work on the builder itself is done. Work needs to be done to integrate the code into the core spring build.

---

1 votes, 10 watchers

[spring-projects-issues]

Chris Beams commented

Jeff, is this still something the Grails team is interested in? The spring-framework build is now happily on Gradle, so should ease the process for you. Let's discuss if you're interested.

[spring-projects-issues]

Jeff Brown commented

Definitely. I will work up a pull request per our discussion.

Thanks.

[spring-projects-issues]

Chris Beams commented

See Jeff's comments at c463fd0#commitcomment-1775388

[spring-projects-issues]

Chris Beams commented

Assigned to myself for review.

[spring-projects-issues]

Jeff Brown commented

Chris,

Are you integrating the lang-groovy subproject into one of the others or are you waiting for me to do that?

[spring-projects-issues]

Chris Beams commented

Thanks for asking - I'm planning to do it.

[spring-projects-issues]

Craig Walls commented

With 3.2.0.RC1 dropping soon and this only existing in a branch, I'm guessing 3.2.0.RC1 won't be seeing Groovy config? Is this a sign that it won't be in 3.2.0 at all? I only ask because I've been asked about this a few times in the past couple of weeks and am not sure how to respond--and honestly, I'd be keen on doing Groovy-based config if it were part of Spring.

[spring-projects-issues]

Chris Beams commented

Craig,

Indeed we had intended to get this in for RC1 but -- with apologies to the Grails team -- we haven't done so in time. At this point we simply won't have enough time for proper feedback on this in the 3.2 cycle, and so must move it forward to 3.3 (which I'm doing now). I'll be following up with Jeff Brown and Guillaume about this as we move into 3.3, where we're considering various options around promoting Groovy anyway.

[spring-projects-issues]

Juergen Hoeller commented

Finally, we got a cut in Spring Framework master now - based on Jeff's latest pull request but heavily refactored and restructured.

The public entry points are org.springframework.beans.factory.groovy.GroovyBeanDefinitionReader and org.springframework.context.support.GenericGroovyApplicationContext now, closely modelled after Spring 3.0's GenericXmlApplicationContext and its relationship with XmlBeanDefinitionReader.

Juergen