LiveBeansView generates invalid JSON on specific case [SPR-11366]

[spring-projects-issues]

Ilayaperumal Gopinathan opened SPR-11366 and commented

In org.springframework.context.support.LiveBeansView, the JSON snapshot of beans has a comma "," at the end of the last bean definition on a specific case when one of these met:

1. If any of the bean definitions in the context's bean factory is of infrastructure bean
2. If the bean is lazily initialized
3. If the bean is not singleton

It looks like the logic to generate the JSON in "generateJson(Set<ConfigurableApplicationContext> contexts)" method adds comma "," to the bean definitions based on the beanNames length. But if any of the above conditions met this adds the comma to the last bean definition as well. This causes the JSON to be invalid.

---

Affects: 3.2 GA, 4.0 GA

Issue Links:

• XD-1271 Investigate missing boot's actuator endpoints in XD

Backported to: 3.2.8

[spring-projects-issues]

Juergen Hoeller commented

Good catch! I've taken the opportunity to refine LiveBeansView's implementation a bit, also extracting an overridable isBeanEligible template method.

Feel free to give this a try with the upcoming 4.0.2 snapshot...

Juergen

[spring-projects-issues]

Ilayaperumal Gopinathan commented

Sure, thanks very much for fixing it!

Ilaya

[spring-projects-issues]

Juergen Hoeller commented

Have you had a chance to give it a try? We're about to release 4.0.2 and 3.2.8 towards the end of this week, so pre-release testing is very welcome...

Juergen

[spring-projects-issues]

Ilayaperumal Gopinathan commented

I just verified the fix from the latest 4.0.2 SNAPSHOT and it looks good.

Thanks again,
Ilaya