You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
changed the title [-]Error in javadoc for o.s.wb.servlet.function.ServerResponse[/-][+]Error in javadoc for o.s.web.servlet.function.ServerResponse[/+]on Jun 3, 2019
The Javadoc should in fact look something more like the following, in order to align with org.springframework.web.reactive.function.server.ServerResponse.writeTo(ServerWebExchange, Context).
/** * Write this response to the given servlet response. * @param request the current request * @param response the response to write to * @param context the context to use when writing * @return a {@code ModelAndView} or {@code null} */@NullableModelAndViewwriteTo(HttpServletRequestrequest, HttpServletResponseresponse, Contextcontext)
throwsServletException, IOException;
@poutsma, can you elaborate on the intended semantics of the @return value, specifically when null is expected as a return value?
Activity
[-]Error in javadoc for o.s.wb.servlet.function.ServerResponse[/-][+]Error in javadoc for o.s.web.servlet.function.ServerResponse[/+]sbrannen commentedon Jun 3, 2019
Good catch.
The Javadoc should in fact look something more like the following, in order to align with
org.springframework.web.reactive.function.server.ServerResponse.writeTo(ServerWebExchange, Context)
.@poutsma, can you elaborate on the intended semantics of the
@return
value, specifically whennull
is expected as a return value?Polish Javadoc