KafkaEmbeddedHolder - topic created but not added.

[nklmish]

NOTE: In order to reproduce this issue locally please clone https://github.com/nklmish/spring-kafka-issue-676 and execute ./gradlew clean test.

I ll like to use the same broker(s) for multiple test classes (garyrussell@24c399e), and saw this example mentioned in docs. However, it seems that topic(s) are created in Kafka (I have verified this) but never appended inside KafkaEmbedded#topics as a result when we try to access a newly created topic, e.g.
embeddedKafka.consumeFromAnEmbeddedTopic(consumer, SOME_TOPIC);
An assertion error gets thrown due to this .

We should update the topic array after this call. I can also submit a PR if the above suggestions sounds reasonable.

Thanks!

[garyrussell]

Agreed; thanks for the offer of a PR. We should not add them when called from before() though; maybe change the array to a Set? That will also save iterating over the array in consumeFromEmbeddedTopics().

[nklmish]

Thank you, set sounds a good idea, however once we change String[] -> Set, we need to choose one of the following paths:
a). Don't change method signature and perform an internal conversion from String[] -> Set (it introduce a penalty for converting list to set in addTopics & consumeFromEmbeddedTopics)
b). Change method signature of addTopics() and consumeFromEmbeddedTopics() to accept Set instead of Strings.... It will introduce backward incompatible changes
c). Deprecate old methods and introduce new ones.
Thoughts ?

[garyrussell]

I would vote for option a) - don't worry about overhead - it's only minor; it's noise compared to everything else going on in the test cases.

[nklmish]

Thanks, we are on the same page, here is the PR #677