GH-3555: Improve docs for KafkaHeaders.CONVERSION_FAILURES#3611
Merged
sobychacko merged 2 commits intospring-projects:mainfrom Nov 11, 2024
Merged
GH-3555: Improve docs for KafkaHeaders.CONVERSION_FAILURES#3611sobychacko merged 2 commits intospring-projects:mainfrom
KafkaHeaders.CONVERSION_FAILURES#3611sobychacko merged 2 commits intospring-projects:mainfrom
Conversation
…LURES` Fixes: spring-projects#3555 Issue link: spring-projects#3555 The batch might be processed in the `@KafkaListener` silently without looking into conversion failures header. So, that might cause in impression that nothing is wrong with the batch. * Mention `KafkaHeaders.CONVERSION_FAILURES` in the docs * Add `warn` for the failed conversion in the `BatchMessagingMessageConverter` * Some other code optimization clean up in the `BatchMessagingMessageConverter`
sobychacko
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3555
Issue link: #3555
The batch might be processed in the
@KafkaListenersilently without looking into conversion failures header. So, that might cause in impression that nothing is wrong with the batch.KafkaHeaders.CONVERSION_FAILURESin the docswarnfor the failed conversion in theBatchMessagingMessageConverterBatchMessagingMessageConverter