Skip to content

Simplify batch error handling tests #1005

Open
@onobc

Description

@onobc

Refactor batch error handling tests in DefaultPulsarConsumerErrorHandlerTests.

  • tests are 98% identical (fix that)
  • make it more clear the magic numbers expected during verification

Tip

Use the recently added whenBatchRecordListenerOneMessageBatchFailsThenSentToDltProperly as a template and make it re-usable.

Originally motivation in #1002 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    theme: testingIssues related to testingtype: improvementAn improvement of implementation of existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions