Skip to content

Enable observations tests #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Oct 11, 2022

Some strange timing going on w/ redelivery of messages across tracing setup runs in ObservationIntegrationTests. Lets see how this change works in CI.

@onobc onobc requested a review from sobychacko October 11, 2022 05:20
@@ -142,11 +142,6 @@ public void doStop() {
}
}

@Override
public void destroy() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was preventing things from closing down on destroy (during tests)

@sobychacko sobychacko merged commit 1a94d40 into spring-projects:main Oct 11, 2022
@sobychacko
Copy link
Collaborator

Looks good. Merged the PR.

@onobc onobc deleted the cbono-obstests-reenable branch October 30, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants