-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: issue with [docker-compose up] command #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docker-compose up
command
Hi @rizahmeds I'll take a look at it. |
Hi @rizahmeds |
Alright @srbhr Thanks! |
hi @rizahmeds , I was getting the below error when i test your code |
Hi @SubramanyamChalla24, Thanks for pointing this out. @srbhr Now i am just wondering, why ![]() |
That is because the user needs to add the config file manually as it contains the private api keys. |
@SubramanyamChalla24 |
I have the latest version. It's not an error with the version though. can you check from your side including the config file? |
Yes, i already checked with the config.yaml file. |
Cohere doesn't require a credit card. Can you check it once?It required a card before but it doesn't need it now.
|
Thanks for the update @SubramanyamChalla24. Yes i have got the Cohere Trial key. ![]() |
Great work in collaboration @rizahmeds and @SubramanyamChalla24 🔥 |
I couldn't replicate it. It still shows the same error though. Probably someone has to try and verify it. |
WalkthroughThe Dockerfile was updated to use the Changes
Assessment against linked issues
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
build.dockerfile (5)
1-2
: Consider pinning to a specific patch version for reproducible builds.The floating tag
python:3.11-slim-bullseye
will track upstream patch releases, which can lead to subtle changes over time. Pin to a known patch (e.g.python:3.11.14-slim-bullseye
) to lock in your build environment.
4-5
: Combine apt steps into one layer & clean up caches.Merging
apt-get update
andinstall
, and trimming APT lists, reduces layers and image size:-RUN apt-get update -RUN apt-get install -y build-essential python-dev git +RUN apt-get update && \ + apt-get install -y --no-install-recommends build-essential python3-dev git && \ + rm -rf /var/lib/apt/lists/*
6-8
: Merge pip upgrade and dependencies & usepython -m pip
.Consolidate into one step and avoid layer cache of wheels:
-RUN pip install -U pip setuptools wheel -COPY requirements.txt requirements.txt -RUN pip install -r requirements.txt +COPY requirements.txt ./ +RUN python -m pip install --upgrade pip setuptools wheel && \ + python -m pip install --no-cache-dir -r requirements.txt
9-9
: Use a.dockerignore
for theCOPY . .
step.Without excluding irrelevant files (e.g.,
.git
, local builds, credentials), the image can bloat and builds slow down. Add a.dockerignore
to filter out unnecessary files.
11-11
: Reconsider runningrun_first.py
at build time.Invoking initialization scripts during image build can bake stale data and slow rebuilds. Consider moving
run_first.py
into the container startup logic (entrypoint/CMD) or a dedicated initialization step.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
build.dockerfile
(1 hunks)
🔇 Additional comments (1)
build.dockerfile (1)
1-2
: Base image updated to Debian Bullseye slim (fixesdocker-compose up
issues).Switching to
python:3.11-slim-bullseye
aligns the OS layer with Debian Bullseye and addresses the previousdocker-compose up
failure locally.
@@ -1,4 +1,5 @@ | |||
FROM python:3.11.0-slim | |||
FROM python:3.11-slim-bullseye | |||
|
|||
WORKDIR /data/Resume-Matcher | |||
RUN apt-get update | |||
RUN apt-get install -y build-essential python-dev git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use python3-dev
instead of python-dev
.
On Bullseye, python-dev
points to Python 2 headers. Installing python3-dev
ensures C extensions target the active Python 3 interpreter.
🤖 Prompt for AI Agents
In build.dockerfile at line 5, replace the package `python-dev` with
`python3-dev` in the apt-get install command to ensure the installation of
Python 3 development headers instead of Python 2, which is outdated on Bullseye.
@rizahmeds thanks for this PR. There's a completely new version of Resume Matcher we've worked up. If you're on Discord we're looking for people who can help in improving that. |
Pull Request Title
Fixed issue, while running command
docker-compose up
locally.Related Issue
Fixes #144
Description
Type
Proposed Changes
python:3.11.0-slim
topython:3.11-slim-bullseye
Screenshots / Code Snippets (if applicable)
How to Test
Checklist
Additional Information
Summary by CodeRabbit