-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: custom version for Kafka #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into feat/custom-product-versions-kafka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you thought of any possibility to integrate the version patching in patchable?
This would ensure reproducibility outside the docker build and allow for a dev to check that the version update is actually correct.
I thought about that as well, but didn't find a good solution yet. But now that I think about it again... I could create a patch file that appends |
So do you still want this PR merged as is first? |
No, I'll adapt it later today |
…into feat/custom-product-versions-kafka
10b9e70
to
856c6ab
Compare
856c6ab
to
b06732c
Compare
@razvan I updated the process now, seems to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming the hive patch in this pr was intentional :)
The Hive patch was already merged in main, I just rebased it into this PR |
Description
Part of #1068
This PR enables custom versions (with a suffix like
-stackable0.0.0-dev
) for Kafka.In the SBOM, the custom version is replaced by the original one (using
sed
), so vulnerabilities filed directly against Kafka are still detected by scanners when scanning the SBOM.I built Kafka 3.9.0, tested it with the smoke test and manually validated that it reported the correct version.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.