Skip to content

Conversation

@jamesross03
Copy link
Contributor

@jamesross03 jamesross03 commented Jul 17, 2025

Overview

Patch to fix a number of small issues and update dependencies. Removes static modifier from DataSet.getCharset() so that the function can be overridden by child classes. Updates utilities dependency to benefit from improved crypto functionality for EncryptedDataSet and also migrates tests to JUnit5.

Closes #7, closes #8 , closes #9, closes #10

Changelist

Refactoring:

  • Removes static modifier from DataSet.getCharset() to allow this function to be overridden by child classes.
  • Address compiler warnings such as raw-types and unused variable and function declarations by adding mitigation and suppress warnings tags as relevant.

Dependencies:

Other:

  • Replaces @SuppressWarnings("UnusedDeclaration") with @SuppressWarnings("unused").
  • Migrate tests in src/main/test to use JUnit5 instead of, the now unsupported, JUnit4.

jar35 added 2 commits July 17, 2025 14:55
Replace IntelliJ specific `@SuppressWarnings("UnusedDeclaration")` with
the more generically recognised `@SuppressWarnings("unused")`. See stacs-srg#8.
@jamesross03 jamesross03 marked this pull request as draft July 21, 2025 14:16
@jamesross03 jamesross03 changed the title 1.1.0-SNAPSHOT patch 1.1.1-SNAPSHOT: Updated utilities version and getCharset patch Jul 21, 2025
@jamesross03 jamesross03 changed the title 1.1.1-SNAPSHOT: Updated utilities version and getCharset patch 1.1.1-SNAPSHOT: Updated utilities version Jul 21, 2025
jamesross03 pushed a commit to jamesross03/population-records that referenced this pull request Jul 22, 2025
Updates [Ciesvium](https://github.com/stacs-srg/ciesvium) dependency to
[`1.1.1-SNAPSHOT`](stacs-srg/ciesvium#6) to stay
up-to-date.
Addresses compiler warnings such as raw-types and unused variable and function declarations by adding mitigation and suppress warnings tags as relevant.
@jamesross03 jamesross03 marked this pull request as ready for review July 25, 2025 12:15
Updates [`common-pom`](https://github.com/stacs-srg/common-pom/) to
[`4.1.0-SNAPSHOT`](stacs-srg/common-pom#5) to
take advantage of updated JDK and JUnit dependencies. See stacs-srg#10
@grahamkirby grahamkirby merged commit a2d0b16 into stacs-srg:master Sep 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update common-pom to 4.1.0-SNAPSHOT Update utilities dependency Replace @SuppressWarnings("UnusedDeclaration") Migrate tests to Junit5

2 participants