-
Notifications
You must be signed in to change notification settings - Fork 1
1.0.1-SNAPSHOT: utilities patch and strict-typing
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates tests to JUnit5 from unsupported JUnit4. See stacs-srg#8
Update the [`utilities`](https://github.com/stacs-srg/utilities/) dependency to [`1.1.0-SNAPSHOT`](stacs-srg/utilities#13) to take advantages of latest patches to bugs in the `measures` package.
utilities patch and JUnit5
utilities patch and JUnit5utilities patch and strict-typing
This was referenced Jul 23, 2025
This reverts commit 32bff69. Unsolves
Corrects inaccurate exception messages in LXP.
Refactors "clazz" variable name for clarity.
Updates Neo4J dependencies to Neo4J 5 (to match image used by data-umea repository) and removes Neo4J server dependency as this is unused and adds unnecessary weight to the package.
Fixed issues caused by change in transaction structure when updating to use Neo4J driver 5+. See stacs-srg#12
jamesross03
pushed a commit
to jamesross03/population-records
that referenced
this pull request
Jul 25, 2025
Updated functions to use `String` data-type for object id rather than `long` for compatibility with Neo4J driver version 5+ (as introduced in [`neo-storr 1.0.1-SNAPSHOT`](stacs-srg/neo-storr#11)).
Update functions to use `String` data-type for object id rather than `long` for compatibility with Neo4J driver version 5+. See stacs-srg#13
Correct type to int (interpeted as String with LXPScalar interface).
Updates Neo4J driver version to 5.26 (in-line with the Neo4J image used by the data-umea repository).
Readds removed neo4J server dependency to address warnings in other repositories implementing Neo-storr as a dependency. Also updates dependency version to 5.26.9. in-line with driver.
Updated the default constructor for NeoDBBridge to use a host URL from a System property, 'NeoDBTestURL', if set. This facilitates unit-testing with JUnit harness.
Enabled JUnit tests as part of the Maven build process and added the Neo4J test harness to emulate the Neo4J dependency. See stacs-srg#14
Disables tests running in parallel to prevent issues with multiple Neo4J test harness instances. See stacs-srg#14
Uses safe parameter insertion to avoid issues with String id.
Updates common-pom to 4.1.0-SNAPSHOT to take advantage of updated JDK and JUnit dependencies. See stacs-srg#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Large patch, updates dependencies to include patches to String
measurespackage (addresses a breaking bug if the Unicode replacement character was encountered). Also implements stricter typing to address compiler warnings and updates unit-tests to use JUnit5 and a Neo4J test harness. Updates Neo4J versions to 5+ to address character encoding issues and refactors all ID's toStringdatatype instead oflong(for compatibility with this update).Closes #7, closes #8, closes #10, closes #12, closes #13, closes #14, closes #15
Changelist
Additions:
Dependencies:
common-pomto4.1.0-SNAPSHOTto take advantage of updated JDK and JUnit dependencies.JUnit5dependency and migrates all tests to use this instead of discontinued JUnit4.utilitiesdependency to1.1.0-SNAPSHOTto take advantages of latest patches to bugs in themeasurespackage.neo4jserver dependency to5.26.9andneo4J.driverto Neo4j5.26.3(to bring in-line with the version used in the data-umea repo).Repository:
Refactoring:
Stringdata-type (instead oflong) for compatibility with Neo4J 5+.Other: