Skip to content

Conversation

@jamesross03
Copy link
Contributor

@jamesross03 jamesross03 commented Jul 23, 2025

Overview

Large patch, updates dependencies to include patches to String measures package (addresses a breaking bug if the Unicode replacement character was encountered). Also implements stricter typing to address compiler warnings and updates unit-tests to use JUnit5 and a Neo4J test harness. Updates Neo4J versions to 5+ to address character encoding issues and refactors all ID's to String datatype instead of long (for compatibility with this update).

Closes #7, closes #8, closes #10, closes #12, closes #13, closes #14, closes #15

Changelist

Additions:

  • Adds a basic README.

Dependencies:

  • Updates common-pom to 4.1.0-SNAPSHOT to take advantage of updated JDK and JUnit dependencies.
  • Adds JUnit5 dependency and migrates all tests to use this instead of discontinued JUnit4.
  • Update the utilities dependency to 1.1.0-SNAPSHOT to take advantages of latest patches to bugs in the measures package.
  • Updated neo4j server dependency to 5.26.9 and neo4J.driver to Neo4j 5.26.3 (to bring in-line with the version used in the data-umea repo).
  • Adds Neo4J test harness to emulate the Neo4J instance for unit-tests.

Repository:

  • Updates Maven target version to JDK 21.
  • Re-enables unit-tests (as these can now run properly due to the presence of the test harness.

Refactoring:

  • Renames "Class clazz" variables to c for clarity/conciseness .
  • Fixes inaccurate exception messages in LXP.
  • Removes unnecessary implementation of super-interface in NeoDbCypherBridge.
  • Refactors all ids to use String data-type (instead of long) for compatibility with Neo4J 5+.

Other:

  • Updated the default constructor for NeoDBBridge to use a host URL from a System property, 'NeoDBTestURL', if set. This facilitates unit-testing with JUnit harness.
  • Disables tests running in parallel to prevent issues with test harnesses clashing with each-other.

jar35 added 5 commits July 22, 2025 19:54
Migrates tests to JUnit5 from unsupported JUnit4. See stacs-srg#8
Update the [`utilities`](https://github.com/stacs-srg/utilities/) dependency to [`1.1.0-SNAPSHOT`](stacs-srg/utilities#13) to take advantages of latest patches to bugs in the `measures` package.
@jamesross03 jamesross03 marked this pull request as draft July 23, 2025 10:58
@jamesross03 jamesross03 changed the title 1.0.1-SNAPSHOT: 1.0.1-SNAPSHOT: utilities patch and JUnit5 Jul 23, 2025
@jamesross03 jamesross03 changed the title 1.0.1-SNAPSHOT: utilities patch and JUnit5 1.0.1-SNAPSHOT: utilities patch and strict-typing Jul 23, 2025
jar35 added 8 commits July 23, 2025 15:29
Corrects inaccurate exception messages in LXP.
Refactors "clazz" variable name for clarity.
Updates Neo4J dependencies to Neo4J 5 (to match image used by data-umea
repository) and removes Neo4J server dependency as this is unused and
adds unnecessary weight to the package.
Fixed issues caused by change in transaction structure when updating to
use Neo4J driver 5+. See stacs-srg#12
jamesross03 pushed a commit to jamesross03/population-records that referenced this pull request Jul 25, 2025
Updated functions to use `String` data-type for object id rather than `long` for compatibility with Neo4J driver version 5+ (as introduced in [`neo-storr 1.0.1-SNAPSHOT`](stacs-srg/neo-storr#11)).
jar35 added 9 commits July 28, 2025 11:47
Update functions to use `String` data-type for object id rather than
`long` for compatibility with Neo4J driver version 5+. See stacs-srg#13
Correct type to int (interpeted as String with LXPScalar interface).
Updates Neo4J driver version to 5.26 (in-line with the Neo4J image used
by the data-umea repository).
Readds removed neo4J server dependency to address warnings in other
repositories implementing Neo-storr as a dependency. Also updates
dependency version to 5.26.9. in-line with driver.
Updated the default constructor for NeoDBBridge to use a host URL from a
System property, 'NeoDBTestURL', if set. This facilitates unit-testing
with JUnit harness.
Enabled JUnit tests as part of the Maven build process and added the
Neo4J test harness to emulate the Neo4J dependency. See stacs-srg#14
Disables tests running in parallel to prevent issues with multiple Neo4J
test harness instances. See stacs-srg#14
jar35 added 2 commits July 31, 2025 22:53
Uses safe parameter insertion to avoid issues with String id.
Updates common-pom to 4.1.0-SNAPSHOT to take advantage of updated JDK
and JUnit dependencies. See stacs-srg#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants