JUnit5 and dependency updates #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 23, 2025 14:44
Updates [`population-records`](https://github.com/stacs-srg/population-records) dependency to [`1.0.2-SNAPSHOT`](stacs-srg/population-records#7) to take advantage of patches to issues such as corrupt characters breaking the String distance measurements. See stacs-srg#22
Migrate tests in src/main/test to use JUnit5 instead of, the now unsupported, JUnit4.
Moved BirthParentsMarriage test class to the tests repository.
Updated all linkage code to use `String` datatype for id fields instead of `long` for compatibility with Neo4J 5+, follows similar changes in [population-records](stacs-srg/population-records#10) and [neo-storr](stacs-srg/neo-storr#13). See issue stacs-srg#26.
Fixes type-errors introduced by updates to dependencies.
Updates [`common-pom`](https://github.com/stacs-srg/common-pom/) to [`4.1.0-SNAPSHOT`](stacs-srg/common-pom#5) to take advantage of updated JDK and JUnit dependencies. See stacs-srg#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrates unit-tests to utilise the JUnit5 platform instead of the no-longer-supported JUnit4. Also updates dependencies to gain benefits of recent patches (such as a patch to to the breaking glitch when calculating String distance, using
utilities.measurespackage in the IJDPS tests, see #20).Closes #21, closes #22, closes #25, closes #28
Changelist
Dependencies:
common-pomto4.1.0-SNAPSHOTto take advantage of updated JDK and JUnit dependencies.population-recordsdependency to1.0.2-SNAPSHOTto take advantage of patches to issues such as corrupt characters breaking the String distance measurements and updates toneo-storrto prevent Swedish characters from becoming corrupt. Also updates transitive dependencies to use Neo4J 5+ for the Neo4J database and driver.JUnit5dependency.Refactoring:
Stringdata-type instead oflongfor identification, for compatibility with Neo4J 5+ (transitive dependency updated inpopulation-records 1.0.2-SNAPSHOT).Testing:
Documentation:
Docker/README.mdtoREADME.md.