1.0.2-SNAPSHOT: patch #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview
Adds unit-testing for RecordRepository, reinstates long ids, and updates to common-pom 4.1.0.
## Commits included
- Updates Hashcode functionality for record_types
- Adds unit-testing for record types
- Implementation of some tests for RecordRepository
- Basic setup for RecordRepository tests, overriding Neo4J using Neo4J
test harness.
- Adds more tests and asserts successful teardown
- Updates `common-pom` to 4.1.0-SNAPSHOT
Updates [`common-pom`](https://github.com/stacs-srg/common-pom/) to
[`4.1.0-SNAPSHOT`](stacs-srg/common-pom#5) to
take advantage of updated JDK and JUnit dependencies. See stacs-srg#13
* Reinstates long ids instead of String ids
Removes remnants of rolled-back updates to neo-storr.
* Implemented more RecordRepository tests
Implemented more thorough testing of the Neo4J backing of
RecordRepository using a test-harness.
---------
Co-authored-by: jar35 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Primarily a patch to the 1.0.2-SNAPSHOT but also updates
common-pomto 4.1.0-SNAPSHOT and adds additional unit-tests for RecordRepository.Closes #8, closes #11, closes #12
Changelist
Fixes:
longids instead ofStringids, removing remnants of rolled-back functionality in neo-storr.Testing:
Dependencies:
common-pomto4.1.0-SNAPSHOTto take advantage of updated JDK and JUnit dependencies. See Updatecommon-pomto4.1.0-SNAPSHOT#12