Skip to content

allow changing size of ridgelines #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 6, 2021
Merged

allow changing size of ridgelines #224

merged 17 commits into from
Oct 6, 2021

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jun 18, 2020

Based on this issue reported on the forums

https://discourse.mc-stan.org/t/bayesplot-mcmc-areas-line-and-grid-width-manipulation/16001

I added a size argument to mcmc_areas() and mcmc_areas_ridges() to control the size (thickness) of the ridgelines.

@jgabry jgabry added the feature label Jun 18, 2020
@jgabry jgabry requested a review from tjmahr June 18, 2020 16:53
@jgabry
Copy link
Member Author

jgabry commented Jun 18, 2020

Travis still isn't working because it times out, but tests pass locally for me.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #224 into master will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   98.58%   98.49%   -0.10%     
==========================================
  Files          31       31              
  Lines        3969     3975       +6     
==========================================
+ Hits         3913     3915       +2     
- Misses         56       60       +4     
Impacted Files Coverage Δ
R/mcmc-intervals.R 98.21% <33.33%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f1a9f...06ec51d. Read the comment docs.

@jgabry
Copy link
Member Author

jgabry commented Jun 19, 2020

All checks now passing via GitHub actions

@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #224 (fc63a9b) into master (665c687) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files          32       32           
  Lines        4146     4156   +10     
=======================================
+ Hits         4078     4088   +10     
  Misses         68       68           
Impacted Files Coverage Δ
R/mcmc-intervals.R 99.24% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665c687...fc63a9b. Read the comment docs.

@jgabry
Copy link
Member Author

jgabry commented Oct 23, 2020

Added visual tests and made sure axis expansion is sufficient to avoid cutting off top of the highest ridgeline (I checked plots with few parameters, medium number of parameters, and many parameters).

Copy link
Collaborator

@tjmahr tjmahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions. Otherwise looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #224 (e908354) into master (5555083) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          32       32           
  Lines        4187     4197   +10     
=======================================
+ Hits         4119     4129   +10     
  Misses         68       68           
Impacted Files Coverage Δ
R/mcmc-intervals.R 99.24% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5555083...e908354. Read the comment docs.

@jgabry jgabry merged commit c6919eb into master Oct 6, 2021
@jgabry jgabry deleted the ridgeline-size branch October 6, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants