fix check for attaching to pre-finalized parent #4161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the BN's head is reorged while shut down, reloading the BN will not assign `BlockRef` to alternate branches. However, blocks from other branches are still present in the database, leading to their descendants incorrectly marked as `UnviableFork`. By restricting the check to blocks that have been finalized, they should be reported as `MissingParent` instead, eventually re-assigning a `BlockRef` to them.
tersec
approved these changes
Sep 22, 2022
|
this looks like it could use a test case |
|
Problem is not fixed with v22.10. If I read correctly, this fix has not been included in that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the BN's head is reorged while shut down, reloading the BN will not assign
BlockRefto alternate branches. However, blocks from other branches are still present in the database, leading to their descendants incorrectly marked asUnviableFork. By restricting the check to blocks that have been finalized, they should be reported asMissingParentinstead, eventually re-assigning aBlockRefto them.