add Capella constants to REST config endpoint #4925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capella constants were missing; if we want to support BLS changes from VC, we need the new domain constant to check compatibility.
cheatfate
reviewed
May 10, 2023
| transactions*: List[Transaction, MAX_TRANSACTIONS_PER_PAYLOAD] | ||
| withdrawals*: Option[List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD]] # [New in Capella] | ||
| withdrawals*: Option[List[Withdrawal, MAX_WITHDRAWALS_PER_PAYLOAD]] |
There was a problem hiding this comment.
I think this should not be Option anymore.
There was a problem hiding this comment.
Hmm, maybe better to combine that with a Deneb compatibility PR (adding excess_data_gas).
Would it still work on local testnets without the Option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capella constants were missing; if we want to support BLS changes from VC, we need the new domain constant to check compatibility.