git bash windows compatibility#249
Conversation
…atibility as rev is not a native bash command on that platform.
* Substituted `pwd | rev | cut -d'/' -f1 | rev` for $(basename $("pwd")) but also could have used `pwd | sed 's#.*/##'` for the same effect
nikhilsaraf
left a comment
nikhilsaraf
left a comment
There was a problem hiding this comment.
@jcperkins12 this fix looks good, thank you.
In order to accept your PR, we need you to agree to the Contributor License Agreement, which you can find here: https://docs.google.com/forms/d/e/1FAIpQLSc5eppq6GOu9-TnFuRMBh4qIP1ChmZx9lrA6zOTyYiowKiwpA/viewform?usp=sf_link
See the document on how to contribute to Kelp for details
|
@nikhilsaraf thank you for looking into it. I thought that I had signed the agreement before I created the pull request. Are you able to tell if it is on record now? If so, is there anything else that you need from me and if not, I can fill out another one, but is there something I need to do differently? The original agreement was associated with the email address jcperkins12@gmail.com |
nikhilsaraf
left a comment
nikhilsaraf
left a comment
There was a problem hiding this comment.
LGTM, have the signed CLA on file now, thanks @jcperkins12 !
If you're interested in taking on any other issues please feel free to submit a PR, or if you want to chat let me know and I'd be happy to help figure it out.
2 participants
This PR address Issue#248.
It replaces the
revcommand which may be common, but not native to bash, with a native bash command that works on the out of the box bash console for windows that can be installed alongside Git.