This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Add tests for volume filter for non-nil base and exact mode#615
Merged
nikhilsaraf merged 10 commits intostellar-deprecated:masterfrom Dec 11, 2020
Merged
Add tests for volume filter for non-nil base and exact mode#615nikhilsaraf merged 10 commits intostellar-deprecated:masterfrom
nikhilsaraf merged 10 commits intostellar-deprecated:masterfrom
Conversation
nikhilsaraf
reviewed
Dec 10, 2020
Contributor
nikhilsaraf
left a comment
nikhilsaraf
left a comment
There was a problem hiding this comment.
added two small inline comments, almost done!
nikhilsaraf
approved these changes
Dec 11, 2020
| // it is not possible for otb = 0 && tbb = 0 and newAmount < 0, so skipping that case | ||
| { | ||
| name: "15. otb > 0 && tbb > 0; projected > cap", | ||
| name: "15. otb > 0 && tbb > 0; projected < cap", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the volume filter for when the base cap is non-nil and the mode is
Exact. Follow up to #611 and #614. Follow-up PR will add tests for non-nil quote and exact.