This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Implement buytwap strategy (closes #522)#630
Merged
nikhilsaraf merged 12 commits intostellar-deprecated:masterfrom Dec 25, 2020
Merged
Implement buytwap strategy (closes #522)#630nikhilsaraf merged 12 commits intostellar-deprecated:masterfrom
nikhilsaraf merged 12 commits intostellar-deprecated:masterfrom
Conversation
nikhilsaraf
reviewed
Dec 23, 2020
Contributor
nikhilsaraf
left a comment
There was a problem hiding this comment.
looks good on review, but will pull the branch and run myself to check for correctness.
Contributor
nikhilsaraf
approved these changes
Dec 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements the buytwap strategy and closes #522. It builds on recent work on implementing buy-side infrastructure across the codebase, including the volume filter, to implement this strategy.