Skip to content

Change serverURL.segment to serverURL.clone().segment() #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shaptic merged 1 commit into from
Dec 1, 2025
Merged

Change serverURL.segment to serverURL.clone().segment() #1296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/horizon/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
* @param {number} seconds Number of seconds past the current time to wait.
* @param {boolean} [_isRetry] True if this is a retry. Only set this internally!
* This is to avoid a scenario where Horizon is horking up the wrong date.
* @returns {Promise<Timebounds>} Promise that resolves a `timebounds` object

Check warning on line 150 in src/horizon/server.ts

View workflow job for this annotation

GitHub Actions / build 

The type 'Timebounds' is undefined
* (with the shape `{ minTime: 0, maxTime: N }`) that you can set the `timebounds` option to.
*/
public async fetchTimebounds(
Expand Down Expand Up @@ -333,7 +333,7 @@
);

return this.httpClient
.post(this.serverURL.segment("transactions").toString(), `tx=${tx}`, {
.post(this.serverURL.clone().segment("transactions").toString(), `tx=${tx}`, {
timeout: SUBMIT_TRANSACTION_TIMEOUT,
headers: { "Content-Type": "application/x-www-form-urlencoded" },
})
Expand Down Expand Up @@ -559,7 +559,7 @@

return this.httpClient
.post(
this.serverURL.segment("transactions_async").toString(),
this.serverURL.clone().segment("transactions_async").toString(),
`tx=${tx}`,
{ headers: { "Content-Type": "application/x-www-form-urlencoded" } },
)
Expand Down
Loading