Skip to content

remove postinstall script and run setup in prepare script#1306

Merged
Ryang-21 merged 1 commit intomasterfrom
remove-post-install
Dec 5, 2025
Merged

remove postinstall script and run setup in prepare script#1306
Ryang-21 merged 1 commit intomasterfrom
remove-post-install

Conversation

@Ryang-21
Copy link
Copy Markdown
Contributor

@Ryang-21 Ryang-21 commented Dec 5, 2025

This pr addresses a bug reported in [discord (https://discord.com/channels/897514728459468821/1082043429053276190/1446310534314987632)

  • The Windows environment does not allow for || true
  • Removes postinstall script all together as it is not the appropriate place to run the setup script
  • Moves the setup script inside the prepare script

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Dec 5, 2025
@Ryang-21 Ryang-21 requested review from a team and Shaptic December 5, 2025 21:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 5, 2025

Size Change: 0 B

Total Size: 42.5 MB

ℹ️ View Unchanged
Filename Size
dist/stellar-sdk-minimal.js 5.56 MB
dist/stellar-sdk-minimal.min.js 4.84 MB
dist/stellar-sdk-no-axios.js 5.56 MB
dist/stellar-sdk-no-axios.min.js 4.84 MB
dist/stellar-sdk-no-eventsource.js 5.8 MB
dist/stellar-sdk-no-eventsource.min.js 5.05 MB
dist/stellar-sdk.js 5.8 MB
dist/stellar-sdk.min.js 5.05 MB

compressed-size-action

@Ryang-21 Ryang-21 merged commit fefcf84 into master Dec 5, 2025
10 checks passed
@Ryang-21 Ryang-21 deleted the remove-post-install branch December 5, 2025 21:32
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants