Working get_todos #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a few rust changes broke
get_todos
. I had to point to my own fork ofnickel.rs
while I'm waiting for nickel-org/rust-http#2 to be merged. I'm happy to wait until that is merged and pointing back to mainlinenickel.rs
before merging this.I implemented
ToJson
onTodo
instead of onVec<Todo>
primarily because we getVec<Todo>.to_json()
for free when doing so. Also, it seems like it might be better to build a layer on top of the core json serialization stuff to get our output a little moreJSON API
-ish. I'm not sure if this is the direction we should go, so input here is greatly appreciated.