fix: Account selects are clearer and sturdier #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeja
changed the title
travis
approved these changes
May 12, 2025
|
code looks good! feel free to merge once the build's green |
Peeja
force-pushed
the
fix-account-selectors
branch
2 times, most recently
from
0965b69 to
99637e9
Compare
|
I've removed the currently-unused |
* `@typescript-eslint/no-unnecessary-condition`: https://typescript-eslint.io/rules/no-unnecessary-condition/ * `import/first`: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/first.md
This will probably come back shortly in a further PR.
This has never been used yet, but will probably come back in a further PR.
Peeja
force-pushed
the
fix-account-selectors
branch
from
aef4953 to
e615235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Dependency Tree
no-unnecessary-condition#139This tree was auto-generated by Charcoal