Skip to content

[bug]: Checkbox missing padding in RTL #1714

Closed
@zaaakher

Description

@zaaakher

What version of strapi-design-system are you using?

[email protected]

[email protected]

@strapi/[email protected]

What's Wrong?

Upon creating this PR in Strapi admin. I realized the checkbox doesn't have a space between the box and the label when the language is RTL.

When LTR

image

When RTL

image

Upon further investigation it seems to be coming from here

To Reproduce

1- Create a <div>

2- Set the property dir to `RTL

3- Place a <Checkbox/> component inside that RTL div.

4- See the lack of space between the label and the box, switch back and forth between rtl and ltr to see the difference.

Expected Behaviour

It should use paddingStart instead of paddingLeft so that it's consistent regardless of direction. I was gonna make a PR for it but handleResponsiveValues.ts looked too complex for me to get through it in the short time I have. So I kindly leave it to you. I appreciate your efforts :)

Metadata

Metadata

Labels

issue: bugIssue reporting a bugstatus: confirmedConfirmed by a Strapi Team member or multiple community members

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions