Convert Breadcrumbs v2 to Typescript #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
pr: chore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -737 B (0%) Total Size: 490 kB
ℹ️ View Unchanged
|
joshuaellis
suggested changes
May 22, 2023
gu-stav
reviewed
May 22, 2023
| } | ||
|
|
||
| export const CrumbSimpleMenu = ({ children, ...props }: CrumbSimpleMenuProps) => ( | ||
| <SimpleMenu icon={<CarretDown />} as={StyledButton} size="S" {...props}> |
There was a problem hiding this comment.
Where did the noBorder prop go? I'm not sure, but I think to remember it is needed, because it behaves, but doesn't look like a simple menu.
There was a problem hiding this comment.
But the SimpleMenu has not the noBorder prop, here you can see the error I had with the noBorder attribute
There was a problem hiding this comment.
Maybe the type definitions are wrong? I'm not sure. In any case: the menu looks broken: https://design-system-git-chore-breadcrumbs-ts-strapijs.vercel.app/?path=/story/design-system-components-v2-breadcrumbs--base
There was a problem hiding this comment.
@simotae14 did you solve this puzzle?
There was a problem hiding this comment.
I've also created an issue, because this is already broken on main: #1090
There was a problem hiding this comment.
ok then I can take a look at the issue. Maybe in the meantime you can review this PR which is unrelated to the bug
joshuaellis
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Converts
Breadcrumbsto TypescriptRelated issue(s)/PR(s)
#983