Skip to content

chore: upgrade to Storybook7 #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

chore: upgrade to Storybook7 #1282

merged 1 commit into from
Aug 16, 2023

Conversation

joshuaellis
Copy link
Contributor

@joshuaellis joshuaellis commented Aug 14, 2023 •
edited
Loading

What does it do?

  • Updates storybook to v7
  • Updates storybook to use typescript
  • Updates storybook to use vite
  • Updates storybook setup so we're aliasing src, no more waiting around for build times to compile ✅
  • Updates storybook to use CSF3.0 & mdx entries
  • Updates playwright to 1.37.0
  • Updates e2e tests to await the story title to appear
  • Applies @strapi/eslint-config to docs

Why is it needed?

  • updates are good
  • The vite version of storybook dynamically loads the stories and as such on a longer wait from the server the test will fail, we now actually do some assertion which has a standard timeout procedure should there be an error
  • CSF3.0 is written in TSX which means we can actually see the issues in our stories, this was a leading factor in how long this upgrade has taken, the eslint config for it all was poor.

Related issue(s)/PR(s)

@joshuaellis joshuaellis added pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: dependencies relates to dependencies within the repo labels Aug 14, 2023
@joshuaellis joshuaellis added this to the 1.9.1 milestone Aug 14, 2023
@joshuaellis joshuaellis requested a review from gu-stav August 14, 2023 15:24
@joshuaellis joshuaellis self-assigned this Aug 14, 2023
@vercel
Copy link

vercel bot commented Aug 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 7:58am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 7:58am

@github-actions

This comment was marked as spam.

Sign in to view
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 7119a2f to b7a20cf Compare August 14, 2023 18:27
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from b7a20cf to d192014 Compare August 15, 2023 07:11
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from d192014 to a6df2e3 Compare August 15, 2023 07:44
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 7b6cae6 to 5c6f8a8 Compare August 15, 2023 07:46
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 065cdd1 to 094f75b Compare August 15, 2023 09:38
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 1541b46 to ab93444 Compare August 15, 2023 20:54
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 3c31678 to ca4892d Compare August 16, 2023 07:03
@joshuaellis
Copy link
Contributor Author

@gu-stav this is now definitely ready for review 👍🏼

@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from ca4892d to 0fd2b9a Compare August 16, 2023 07:21
@joshuaellis joshuaellis force-pushed the chore/update-storybook branch from 0fd2b9a to e129041 Compare August 16, 2023 07:54
@joshuaellis joshuaellis removed this from the 1.9.1 milestone Aug 16, 2023
gu-stav
gu-stav approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very readable, very clean & blazing fast updates. I like it.

@joshuaellis joshuaellis merged commit b5b99e6 into main Aug 16, 2023
@joshuaellis joshuaellis deleted the chore/update-storybook branch August 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gu-stav gu-stav gu-stav approved these changes

@simotae14 simotae14 Awaiting requested review from simotae14

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: dependencies relates to dependencies within the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Storybook webpack not reloading after vite bundles primitives package
2 participants
@joshuaellis @gu-stav